Initializers for joining a sequence of predicates#1878
Open
MatthewTurk247 wants to merge 4 commits intoswiftlang:mainfrom
Open
Initializers for joining a sequence of predicates#1878MatthewTurk247 wants to merge 4 commits intoswiftlang:mainfrom
MatthewTurk247 wants to merge 4 commits intoswiftlang:mainfrom
Conversation
jmschonfeld
reviewed
Apr 6, 2026
jmschonfeld
approved these changes
Apr 15, 2026
Contributor
|
@swift-ci please test |
Contributor
|
The build failures look to be caused by this change: |
Contributor
Author
|
Type inference is not working as I was expecting. I’ll add explicit annotations. |
jmschonfeld
reviewed
Apr 15, 2026
|
|
||
| if let guarded = iterator.next() { | ||
| self.init({ (input: repeat PredicateExpressions.Variable<each Input>) in | ||
| let condition: PredicateExpressions.Value<Self> = PredicateExpressions.build_Arg(guarded) |
Contributor
There was a problem hiding this comment.
The change to pieces makes sense to me, but for condition should we just create it directly via
let condition = PredicateExpressions.Value(guarded)No need to go through the builder functions here if they're getting in the way, especially build_Arg - it's really for the macro which doesn't know what the return type should be, but since we know it we can just create the Value directly if it helps the type checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the initializers proposed in #1860.
Testing:
See
PredicateTests/all()andPredicateTests/any().